Allow to configure a different metamodel#449
Merged
Merged
Conversation
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //src:license-checkStatus: Click to expand output |
|
The created documentation from the pull request is available at: docu-html |
a-zw
requested review from
AlexanderLanin,
MaximilianSoerenPollak,
dcalavrezo-qorix and
nradakovic
as code owners
Contributor
Author
|
Chat with Max: Looks like the right direction. Wait until after 0.7 release before merging this. |
Contributor
MaximilianSoerenPollak
left a comment
MaximilianSoerenPollak
left a comment
There was a problem hiding this comment.
Some questions, but overall looks good and seems like a good feature to add.
There was a problem hiding this comment.
Pull request overview
Adds support for loading a custom metamodel.yaml for the score_metamodel Sphinx extension, primarily to enable downstream/internal reuse with extended metamodels and checks (Issue #415).
Changes:
- Make
load_metamodel_data()accept an optional YAML path and wire it through the Sphinx extension via a newscore_metamodel_yamlconfig value. - Plumb a new
metamodelparameter through the Bazeldocs()macro and the incremental build driver so the custom YAML can be selected at build time. - Document the new macro parameter and add a targeted unit test for explicit-path loading.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/incremental.py | Reads SCORE_METAMODEL_YAML and forwards it to Sphinx as score_metamodel_yaml. |
| src/extensions/score_metamodel/yaml_parser.py | Allows loading metamodel data from a caller-provided path (defaults to bundled YAML). |
| src/extensions/score_metamodel/init.py | Adds score_metamodel_yaml config value and loads metamodel from override path when set. |
| src/extensions/score_metamodel/tests/test_metamodel_load.py | Adds test verifying explicit YAML path is honored. |
| docs.bzl | Adds metamodel arg and threads it into Bazel-driven doc targets. |
| docs/reference/bazel_macros.rst | Documents new metamodel argument for docs() macro. |
| docs/how-to/setup.md | Updates docs() parameter table to include metamodel (and related params). |
AlexanderLanin
approved these changes
May 11, 2026
github-project-automation
Bot
moved this from Backlog
to Done
in INF - Infrastructure Community
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #415
📌 Description
🚨 Impact Analysis
✅ Checklist